netdev - Re: [PATH net] net/sched: ets: fix crash when flipping from 'strict' to 'quantum'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpWRZCS0=v7xGP_ce4RtCt0RwZDTjK1=6AueT_jLOJSYwg@mail.gmail.com>
Date:   Fri, 3 Sep 2021 16:50:43 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Jakub Kicinski <kuba@...nel.org>,
        Hangbin Liu <liuhangbin@...il.com>,
        Petr Machata <petrm@...lanox.com>
Subject: Re: [PATH net] net/sched: ets: fix crash when flipping from 'strict'
 to 'quantum'

On Wed, Sep 1, 2021 at 1:54 PM Davide Caratti <dcaratti@...hat.com> wrote:
> uh, maybe I get the point.
>
> we can do a INIT_LIST_HEAD(&cl[i].alist) in ets_qdisc_init() with 'i' ranging
> from 0 to TCQ_ETS_MAX_BANDS - 1, then the memset() in [1] needs to be
> replaced with something that clears all members of struct ets_class except
> 'alist'. At this point, the INIT_LIST_HEAD() line in ets_qdisc_change() can be
> removed.
>
> I can re-run the kseltest and eventually send a patch for that (targeting
> net-next, no need to rush), is that ok for you?

Sure, whatever works for you.

Thanks.