netdev - Re: [PATCH] iwlwifi: pnvm: Fix a memory leak in 'iwl_pnvm_get_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecb513984c95f69c4fb773591d873d795f344174.camel@intel.com>
Date:   Fri, 3 Sep 2021 08:55:27 +0000
From:   "Coelho, Luciano" <luciano.coelho@...el.com>
To:     "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "christophe.jaillet@...adoo.fr" <christophe.jaillet@...adoo.fr>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "Berg, Johannes" <johannes.berg@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "drorx.moshe@...el.com" <drorx.moshe@...el.com>,
        "kuba@...nel.org" <kuba@...nel.org>
Subject: Re: [PATCH] iwlwifi: pnvm: Fix a memory leak in
 'iwl_pnvm_get_from_fs()'

On Fri, 2021-09-03 at 11:19 +0300, Dan Carpenter wrote:
> On Thu, Sep 02, 2021 at 10:38:11PM +0200, Christophe JAILLET wrote:
> > A firmware is requested but never released in this function. This leads to
> > a memory leak in the normal execution path.
> > 
> > Add the missing 'release_firmware()' call.
> > Also introduce a temp variable (new_len) in order to keep the value of
> > 'pnvm->size' after the firmware has been released.
> > 
> > Fixes: cdda18fbbefa ("iwlwifi: pnvm: move file loading code to a separate function")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Luca Coelho <luca@...lho.fi>

Kalle, can you please queue this for v5.15? I'll assign it to you. 
Thanks! 

--
Cheers,
Luca.