netdev - Re: [PATCH net] ip_gre: validate csum_start only if CHECKSUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0UeH3aTnMKqzmtqfWrtmkW6cB=Mk6OSJi0FvmDEbmNAd+Q@mail.gmail.com>
Date:   Sun, 5 Sep 2021 08:53:08 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     Netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Ido Schimmel <idosch@...sch.org>,
        chouhan.shreyansh630@...il.com
Subject: Re: [PATCH net] ip_gre: validate csum_start only if CHECKSUM_PARTIAL

On Sun, Sep 5, 2021 at 8:24 AM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> On Sat, Sep 4, 2021 at 7:47 PM Alexander Duyck
> <alexander.duyck@...il.com> wrote:

<snip>

> > You can do it since you have essentially already written half the code.. :)
>
> Sent, but only the ipv4 patch.
>
> I actually do not see an equivalent skb_pull path in ip6_gre.c. Will
> take a closer look later, but don't have time for that now.
>
> https://patchwork.kernel.org/project/netdevbpf/patch/20210905152109.1805619-1-willemdebruijn.kernel@gmail.com/

So does that mean that commit 9cf448c200ba ("ip6_gre: add validation
for csum_start") is adding overhead that doesn't really address
anything, and is introducing false positives? If so, should we just
revert it?

Thanks,

- Alex