netdev - Re: [PATCH -net] wireless: iwlwifi: fix printk format warnings in uefi.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Sep 2021 07:21:22 +0000
From:   "Coelho, Luciano" <luciano.coelho@...el.com>
To:     "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>, lkp <lkp@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH -net] wireless: iwlwifi: fix printk format warnings in
 uefi.c

On Sun, 2021-09-05 at 12:07 -0700, Randy Dunlap wrote:
> On 8/20/21 7:09 PM, Randy Dunlap wrote:
> > The kernel test robot reports printk format warnings in uefi.c, so
> > correct them.
> > 
> > ../drivers/net/wireless/intel/iwlwifi/fw/uefi.c: In function 'iwl_uefi_get_pnvm':
> > ../drivers/net/wireless/intel/iwlwifi/fw/uefi.c:52:30: warning: format '%zd' expects argument of type 'signed size_t', but argument 7 has type 'long unsigned int' [-Wformat=]
> >     52 |                              "PNVM UEFI variable not found %d (len %zd)\n",
> >        |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >     53 |                              err, package_size);
> >        |                                   ~~~~~~~~~~~~
> >        |                                   |
> >        |                                   long unsigned int
> > ../drivers/net/wireless/intel/iwlwifi/fw/uefi.c:59:29: warning: format '%zd' expects argument of type 'signed size_t', but argument 6 has type 'long unsigned int' [-Wformat=]
> >     59 |         IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %zd\n", package_size);
> >        |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~
> >        |                                                                    |
> >        |                                                                    long unsigned int
> > 
> > Fixes: 84c3c9952afb ("iwlwifi: move UEFI code to a separate file")
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Reported-by: kernel test robot <lkp@...el.com>
> > Cc: Kalle Valo <kvalo@...eaurora.org>
> > Cc: Luca Coelho <luciano.coelho@...el.com>
> > Cc: linux-wireless@...r.kernel.org
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > ---
> >   drivers/net/wireless/intel/iwlwifi/fw/uefi.c |    4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > --- linux-next-20210820.orig/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
> > +++ linux-next-20210820/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
> > @@ -49,14 +49,14 @@ void *iwl_uefi_get_pnvm(struct iwl_trans
> >   	err = efivar_entry_get(pnvm_efivar, NULL, &package_size, data);
> >   	if (err) {
> >   		IWL_DEBUG_FW(trans,
> > -			     "PNVM UEFI variable not found %d (len %zd)\n",
> > +			     "PNVM UEFI variable not found %d (len %lu)\n",
> >   			     err, package_size);
> >   		kfree(data);
> >   		data = ERR_PTR(err);
> >   		goto out;
> >   	}
> >   
> > 
> > -	IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %zd\n", package_size);
> > +	IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %lu\n", package_size);
> >   	*len = package_size;
> >   
> > 
> >   out:
> > 
> 
> Hm, no one has commented on this and the robot is still reporting it as
> build warnings.
> Do I need to resend it?

No need to resend.  Kalle, can you take this directly to wireless-
drivers? I have assigned it to you in patchwork.

--
Cheers,
Luca.