netdev - Re: bridge.c:157:11: error: variable 'err' is used uninitialized whenever 'if' condition is false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <452cbfe701b1373c871ba584ef4b249a59d8edd6.camel@nvidia.com>
Date:   Tue, 7 Sep 2021 20:34:39 +0000
From:   Saeed Mahameed <saeedm@...dia.com>
To:     "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        Vlad Buslov <vladbu@...dia.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "lkft-triage@...ts.linaro.org" <lkft-triage@...ts.linaro.org>,
        "natechancellor@...il.com" <natechancellor@...il.com>,
        "clang-built-linux@...glegroups.com" 
        <clang-built-linux@...glegroups.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "ndesaulniers@...gle.com" <ndesaulniers@...gle.com>,
        "naresh.kamboju@...aro.org" <naresh.kamboju@...aro.org>
Subject: Re: bridge.c:157:11: error: variable 'err' is used uninitialized
 whenever 'if' condition is false

On Mon, 2021-09-06 at 20:35 +0300, Vlad Buslov wrote:
> On Mon 06 Sep 2021 at 19:39, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
> > On Mon, Sep 6, 2021 at 2:11 AM Naresh Kamboju
> > <naresh.kamboju@...aro.org> wrote:
> > > 
> > > drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c:157:11:
> > > error:
> > > variable 'err' is used uninitialized whenever 'if' condition is
> > > false
> > 
> > That compiler warning (now error) seems to be entirely valid.
> 
> I agree, this is a real issue. It had been reported before and my fix
> for it was submitted by Saeed last week but wasn't accepted since it
> was
> part of larger series that also included features and net-next had
> already been closed by that time. As far as I understand it is
> pending
> submission to net as part of series of bug fixes. Sorry for the
> delay.
> 
> 

yes, the fix will be submitted shortly to net/rc branch.
due to bad net-next timing the patch couldn't make it to -next.