netdev - Re: ip6mr: Indentation not proper in ip6mr_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210908093315.404558c6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 8 Sep 2021 09:33:15 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ujjal Roy <royujjal@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        James Morris <jmorris@...ei.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Kernel <netdev@...r.kernel.org>
Subject: Re: ip6mr: Indentation not proper in ip6mr_cache_report()

On Wed, 8 Sep 2021 07:55:45 +0530 Ujjal Roy wrote:
> Hi All,
> 
> Before sending the patch, I am writing this email to get your
> attention please. As per my knowledge I can see ip6mr_cache_report()
> has some indentation issues. Please have a look at the line 1085.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ipv6/ip6mr.c#n1085
> 
> Sharing a patch based on the latest stable Linux.

Please repost with the patch being inline in the email.

Try to use git format-patch and git send-email for best results.

The subject prefix should be [PATCH net-next].

Regarding the change itself - since you're changing this code could you
also remove the ifdef? Instead of:

#ifdef CONFIG_IPV6_PIMSM_V2                                                     
        if (assert == MRT6MSG_WHOLEPKT) { 

do:

	if (IS_ENABLED(CONFIG_IPV6_PIMSM_V2) && assert == MRT6MSG_WHOLEPKT) {