netdev - Re: [PATCH] net: fix tp->undo_retrans accounting in tcp_sacktag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Sep 2021 09:41:07 -0400
From:   Neal Cardwell <ncardwell@...gle.com>
To:     zhenggy <zhenggy@...natelecom.cn>
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org, kuba@...nel.org
Subject: Re: [PATCH] net: fix tp->undo_retrans accounting in tcp_sacktag_one()

On Thu, Sep 9, 2021 at 9:38 AM Neal Cardwell <ncardwell@...gle.com> wrote:
>
> On Thu, Sep 9, 2021 at 6:34 AM zhenggy <zhenggy@...natelecom.cn> wrote:
> >
> > Commit a71d77e6be1e ("tcp: fix segment accounting when DSACK range covers
> > multiple segments") fix some DSACK accounting for multiple segments.
> > In tcp_sacktag_one(), we should also use the actual DSACK rang(pcount)
> > for tp->undo_retrans accounting.
> >
> > Signed-off-by: zhenggy <zhenggy@...natelecom.cn>

Another nit: in the commit title, rather than "net":

  net: fix tp->undo_retrans accounting in tcp_sacktag_one()

...I would suggest the more specific "tcp", which is more typical for
commits fixing tcp*.c files:

  tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()

thanks,
neal