netdev - Re: Please add 2dce224f469f ("netns: protect netns ID lookups with RCU") to LTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <756E20E4-399D-45ED-AA9A-BB351C865C65@oracle.com>
Date:   Fri, 10 Sep 2021 14:22:32 +0000
From:   Haakon Bugge <haakon.bugge@...cle.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     Sasha Levin <sashal@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Linux-Net <netdev@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        OFED mailing list <linux-rdma@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Guillaume Nault <gnault@...hat.com>
Subject: Re: Please add 2dce224f469f ("netns: protect netns ID lookups with
 RCU") to LTS



> On 9 Sep 2021, at 15:30, Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> On Thu, Sep 09, 2021 at 01:10:05PM +0000, Haakon Bugge wrote:
>> Hi Greg & Sasha,
>> 
>> 
>> tl;dr: Please add 2dce224f469f ("netns: protect netns ID lookups with
>> RCU") to the stable releases from v5.4 and older. It fixes a
>> spin_unlock_bh() in peernet2id() called with IRQs off. I think this
>> neat side-effect of commit 2dce224f469f was quite un-intentional,
>> hence no Fixes: tag or CC: stable.
> 
> Please provide a working backport for all of the relevant kernel
> verisons, as it does not apply cleanly on it's own.

I've done the backports. 4.9 is actually not needed, because it uses spin_{lock,unlock}_irqsave() in peernet2id(). Hence, we have an "offending" commit which this one fixes:

fba143c66abb ("netns: avoid disabling irq for netns id")

Will get'm out during the weekend.


Thxs, Håkon