netdev - Re: [PATCH] net: dsa: qca8k: fix kernel panic with legacy mdio mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 11 Sep 2021 17:44:14 +0200
From:   Ansuel Smith <ansuelsmth@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: qca8k: fix kernel panic with legacy mdio
 mapping

On Sat, Sep 11, 2021 at 06:40:55PM +0300, Vladimir Oltean wrote:
> On Sat, Sep 11, 2021 at 05:36:40PM +0200, Ansuel Smith wrote:
> > > > +static int
> > > > +qca8k_internal_mdio_write(struct mii_bus *salve_bus, int phy, int regnum, u16 data)
> > > > +{
> > > > +	struct qca8k_priv *priv = salve_bus->priv;
> > > 
> > > You are only moving code here but while at it, mind fixing that typo?
> > >
> > 
> > I think I didn't understand what you mean here.
> > Sure I will fix the typo and sorry about it.
> > Aside from that anything wrong with the 2 new function or there is a
> > better fix that I can't think of.
> 
> "salve" is "hello" in Italian, and even though that is a greeting,
> surely that is not what was meant, but rather "slave". So even though
> that is less positive, it is at least a technical term with a clear
> meaning, so I think Florian's request was to replace "salve" with
> "slave" while you are moving the code anyway.

Ok this is embarrassing... Typo by vscode autocorrection... Fixing that
and sending v2. Again sorry.