netdev - Re: [net,v2] net: dsa: lantiq_gswip: Add 200ms assert delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0989c27-e799-cc73-e471-e7bd87934e81@hauke-m.de>
Date:   Sun, 12 Sep 2021 14:14:16 +0200
From:   Hauke Mehrtens <hauke@...ke-m.de>
To:     Aleksander Jan Bajkowski <olek2@...pl>, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com,
        davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Subject: Re: [net,v2] net: dsa: lantiq_gswip: Add 200ms assert delay

On 9/12/21 1:58 PM, Aleksander Jan Bajkowski wrote:
> The delay is especially needed by the xRX300 and xRX330 SoCs. Without
> this patch, some phys are sometimes not properly detected.
> 
> The patch was tested on BT Home Hub 5A and D-Link DWR-966.
> 
> Fixes: a09d042b0862 ("net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@...pl>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

Acked-by: Hauke Mehrtens <hauke@...ke-m.de>

> ---
>   drivers/net/dsa/lantiq_gswip.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
> index 64d6dfa83122..267324889dd6 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -1885,6 +1885,12 @@ static int gswip_gphy_fw_load(struct gswip_priv *priv, struct gswip_gphy_fw *gph
>   
>   	reset_control_assert(gphy_fw->reset);
>   
> +	/* The vendor BSP uses a 200ms delay after asserting the reset line.
> +	 * Without this some users are observing that the PHY is not coming up
> +	 * on the MDIO bus.
> +	 */
> +	msleep(200);
> +
>   	ret = request_firmware(&fw, gphy_fw->fw_name, dev);
>   	if (ret) {
>   		dev_err(dev, "failed to load firmware: %s, error: %i\n",
>