netdev - Re: [PATCH v3] tcp: fix tp->undo_retrans accounting in tcp_sacktag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210913085205.531d435a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 13 Sep 2021 08:52:05 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     zhenggy <zhenggy@...natelecom.cn>
Cc:     ncardwell@...gle.com, netdev@...r.kernel.org, edumazet@...gle.com,
        davem@...emloft.net, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
        ycheng@...gle.com, qitiepeng@...natelecom.cn,
        wujianguo@...natelecom.cn, liyonglong@...natelecom.cn
Subject: Re: [PATCH v3] tcp: fix tp->undo_retrans accounting in
 tcp_sacktag_one()

On Mon, 30 Aug 2021 05:00:10 -0400 zhenggy wrote:
> Commit 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit
> time") may directly retrans a multiple segments TSO/GSO packet without
> split, Since this commit, we can no longer assume that a retransmitted
> packet is a single segment.
> 
> This patch fixes the tp->undo_retrans accounting in tcp_sacktag_one()
> that use the actual segments(pcount) of the retransmitted packet.
> 
> Before that commit (10d3be569243), the assumption underlying the
> tp->undo_retrans-- seems correct.
> 
> Fixes: 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit time")
> 

Please remove this empty line. There should be no empty lines between
tags.

> Signed-off-by: zhenggy <zhenggy@...natelecom.cn>

Please fix the data on your system and repost. I'm pretty sure this
wasn't posted on Aug 30th.