netdev - Re: [PATCH net-next 8/8] net: dsa: rtl8366: Drop and depromote pointless prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89a84601-7103-d77d-23a6-2ec8d2f4dfc2@gmail.com>
Date:   Mon, 13 Sep 2021 11:13:18 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Mauri Sandberg <sandberg@...lfence.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        DENG Qingfang <dqfext@...il.com>
Subject: Re: [PATCH net-next 8/8] net: dsa: rtl8366: Drop and depromote
 pointless prints



On 9/13/2021 10:38 AM, Vladimir Oltean wrote:
> On Mon, Sep 13, 2021 at 10:35:53AM -0700, Florian Fainelli wrote:
>> On 9/13/2021 7:43 AM, Linus Walleij wrote:
>>> We don't need a message for every VLAN association, dbg
>>> is fine. The message about adding the DSA or CPU
>>> port to a VLAN is directly misleading, this is perfectly
>>> fine.
>>>
>>> Cc: Vladimir Oltean <olteanv@...il.com>
>>> Cc: Mauri Sandberg <sandberg@...lfence.com>
>>> Cc: Alvin Šipraga <alsi@...g-olufsen.dk>
>>> Cc: Florian Fainelli <f.fainelli@...il.com>
>>> Cc: DENG Qingfang <dqfext@...il.com>
>>> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
>>
>> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
>>
>> Maybe at some point we should think about moving that kind of debugging
>> messages towards the DSA core, and just leave drivers with debug prints that
>> track an internal state not visible to the DSA framework.
> 
> I have some trace points on the bridge driver and in DSA for FDB
> entries, maybe something along those lines?

Yes trace points would work really well, thanks!
-- 
Florian