netdev - Re: [PATCH net-next 5/8] net: dsa: rtl8366: Disable "4K" VLANs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYTZob+dYuYEdHtBQC8K6z1zV5SnB2Xc62XFPJnK-XiXg@mail.gmail.com>
Date:   Tue, 14 Sep 2021 15:12:49 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     DENG Qingfang <dqfext@...il.com>
Cc:     Vladimir Oltean <olteanv@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Mauri Sandberg <sandberg@...lfence.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>
Subject: Re: [PATCH net-next 5/8] net: dsa: rtl8366: Disable "4K" VLANs

On Tue, Sep 14, 2021 at 8:29 AM DENG Qingfang <dqfext@...il.com> wrote:

> > Yeah it is pretty weird. What happens now is that this is a regression
> > when using OpenWrt userspace as it sets up the VLANs like this,
>
> Were you running net-next kernel?

Yep just the userspace is from OpenWrt, the kernel is latest mainline.

> The DSA core already adds the CPU port to VLAN members for you.
> In file net/dsa/slave.c, function dsa_slave_vlan_add:

Hmmmmm I will look into this. Put in some debug prints etc.
Certainly the callbacks to the driver for doing this aren't getting
called even with v5.15-rc1 AFAICT.

Yours,
Linus Walleij