netdev - Re: [PATCH -net] ptp: dp83640: don't define PAGE0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YT/ryFmv/T95UJqn@lunn.ch>
Date:   Tue, 14 Sep 2021 02:24:40 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     netdev@...r.kernel.org, Geert Uytterhoeven <geert@...ux-m68k.org>,
        Richard Cochran <richard.cochran@...cron.at>,
        John Stultz <john.stultz@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH -net] ptp: dp83640: don't define PAGE0

On Mon, Sep 13, 2021 at 03:06:05PM -0700, Randy Dunlap wrote:
> Building dp83640.c on arch/parisc/ produces a build warning for
> PAGE0 being redefined. Since the macro is not used in the dp83640
> driver, just make it a comment for documentation purposes.
> 
> In file included from ../drivers/net/phy/dp83640.c:23:
> ../drivers/net/phy/dp83640_reg.h:8: warning: "PAGE0" redefined
>     8 | #define PAGE0                     0x0000
>                  from ../drivers/net/phy/dp83640.c:11:
> ../arch/parisc/include/asm/page.h:187: note: this is the location of the previous definition
>   187 | #define PAGE0   ((struct zeropage *)__PAGE_OFFSET)
> 
> Fixes: cb646e2b02b2 ("ptp: Added a clock driver for the National Semiconductor PHYTER.")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Richard Cochran <richard.cochran@...cron.at>
> Cc: John Stultz <john.stultz@...aro.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Heiner Kallweit <hkallweit1@...il.com>
> Cc: Russell King <linux@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew