netdev - Re: [PATCH V3 net-next 2/4] ethtool: extend coalesce setting uAPI with CQE mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210914104741.78b21e72@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 14 Sep 2021 10:47:41 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Julian Wiedmann <jwi@...ux.ibm.com>
Cc:     Yufeng Mo <moyufeng@...wei.com>, davem@...emloft.net,
        netdev@...r.kernel.org, shenjian15@...wei.com,
        lipeng321@...wei.com, yisen.zhuang@...wei.com,
        linyunsheng@...wei.com, huangguangbin2@...wei.com,
        chenhao288@...ilicon.com, salil.mehta@...wei.com,
        linuxarm@...wei.com, linuxarm@...neuler.org, dledford@...hat.com,
        jgg@...pe.ca, netanel@...zon.com, akiyano@...zon.com,
        thomas.lendacky@....com, irusskikh@...vell.com,
        michael.chan@...adcom.com, edwin.peer@...adcom.com,
        rohitm@...lsio.com, jacob.e.keller@...el.com,
        ioana.ciornei@....com, vladimir.oltean@....com,
        sgoutham@...vell.com, sbhatta@...vell.com, saeedm@...dia.com,
        ecree.xilinx@...il.com, grygorii.strashko@...com,
        merez@...eaurora.org, kvalo@...eaurora.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH V3 net-next 2/4] ethtool: extend coalesce setting uAPI
 with CQE mode

On Tue, 14 Sep 2021 20:31:29 +0300 Julian Wiedmann wrote:
> > -	if (!dev->ethtool_ops->set_coalesce)
> > +	if (!dev->ethtool_ops->set_coalesce && !dev->ethtool_ops->get_coalesce)
> >  		return -EOPNOTSUPP;
> >    
> 
> This needs to be
> 
> 	if (!set_coalesce || !get_coalesce)
> 		return -EOPNOTSUPP;
> 
> Otherwise you end up calling a NULL pointer below if just _one_ of the
> callbacks is available.

Good catch, care to send a fix?