netdev - [PATCH ethtool 0/5] ethtool: Module EEPROM fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Sep 2021 14:27:33 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     netdev@...r.kernel.org
Cc:     mkubecek@...e.cz, kuba@...nel.org, andrew@...n.ch,
        f.fainelli@...il.com, vadimp@...dia.com, mlxsw@...dia.com,
        vladyslavt@...dia.com, moshe@...dia.com, popadrian1996@...il.com,
        Ido Schimmel <idosch@...dia.com>
Subject: [PATCH ethtool 0/5] ethtool: Module EEPROM fixes

From: Ido Schimmel <idosch@...dia.com>

This patchset contains fixes for various issues I noticed while working
on the module EEPROM parsing code.

In addition to these fixes, I have the following submissions ready for
the next branch [1]:

* Trivial coding style / documentation changes

* Reworking the EEPROM parsing code to use a memory map with pointers to
  individual pages as the current state is sub-optimal. In the IOCTL path,
  one large buffer is passed to parsers (e.g., SFF-8636, CMIS). In the
  netlink path, individual pages are passed, some of which might not be
  valid. With the proposed changes, the IOCTL and netlink paths only
  differ in the way they initialize the memory map. The parsing code is
  completely shared

* Extending the CMIS parser to request and parse diagnostic information
  (already present in SFF-8636) from optional / banked pages

[1] https://github.com/idosch/ethtool/commits/submit/cmis_dump_v1

Ido Schimmel (5):
  sff-8636: Fix parsing of Page 03h in IOCTL path
  cmis: Fix invalid memory access in IOCTL path
  netlink: eeprom: Fallback to IOCTL when a complete hex/raw dump is
    requested
  ethtool: Fix compilation warning when pretty dump is disabled
  netlink: eeprom: Fix compilation when pretty dump is disabled

 cmis.c                  |  2 +-
 ethtool.c               | 13 ++++++++-----
 netlink/module-eeprom.c | 14 ++++++++++++++
 qsfp.c                  |  2 +-
 4 files changed, 24 insertions(+), 7 deletions(-)

-- 
2.31.1