netdev - Re: [PATCH] bnx2x: Fix enabling network interfaces without VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Sep 2021 19:28:15 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shai Malin <smalin@...vell.com>, Adrian Bunk <bunk@...nel.org>
Cc:     Ariel Elior <aelior@...vell.com>,
        Sudarsana Reddy Kalluru <skalluru@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bnx2x: Fix enabling network interfaces without VFs

On Mon, 13 Sep 2021 11:18:33 +0000 Shai Malin wrote:
> On 9/12/2021 at 1:42PM, Adrian Bunk Wrote:
> > On Mon, Sep 13, 2021 at 08:14:33AM +0000, Shai Malin wrote:  
> > > Thanks for reporting this issue!
> > > But the complete fix should also not use "goto failed".
> > > Instead, please create a new "goto skip_vfs" so it will skip
> > > the log of "Failed err=".  
> > 
> > Is this really desirable?
> > It is a debug print not enabled by default,
> > and trying to enable SR-IOV did fail.  
> 
> I agree.
> 
> Acked-by: Shai Malin <smalin@...vell.com>

Applied, thanks!