netdev - Re: [PATCH 3/3] net: macb: add support for mii on rgmii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUNAqSz3sUPqoGx6@lunn.ch>
Date:   Thu, 16 Sep 2021 15:03:37 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Claudiu Beznea <claudiu.beznea@...rochip.com>
Cc:     nicolas.ferre@...rochip.com, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] net: macb: add support for mii on rgmii

On Wed, Sep 15, 2021 at 09:47:21AM +0300, Claudiu Beznea wrote:
> Cadence IP has option to enable MII support on RGMII interface. This
> could be selected though bit 28 of network control register. This option
> is not enabled on all the IP versions thus add a software capability to
> be selected by the proper implementation of this IP.

Hi Claudiu

You are adding a feature without a user. That is generally not
accepted. Could you please also extend one of the macb_config structs
to make use of this?

Thanks
	Andrew