netdev - Re: [RFC PATCH v2 net-next 0/5] Let phylink manage in-band AN for the PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210916140740.7fsw2mk32chxhjwd@skbuf>
Date:   Thu, 16 Sep 2021 14:07:40 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Michael Walle <michael@...le.cc>
CC:     "Russell King (Oracle)" <linux@...linux.org.uk>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Antoine Tenart <atenart@...nel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Maxim Kochetkov <fido_max@...ox.ru>,
        Bjarni Jonasson <bjarni.jonasson@...rochip.com>,
        Steen Hegelund <steen.hegelund@...rochip.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [RFC PATCH v2 net-next 0/5] Let phylink manage in-band AN for the
 PHY

On Thu, Sep 16, 2021 at 04:05:20PM +0200, Michael Walle wrote:
> Am 2021-09-16 15:54, schrieb Vladimir Oltean:
> > On Thu, Sep 16, 2021 at 03:51:28PM +0200, Michael Walle wrote:
> > > Am 2021-09-16 15:09, schrieb Vladimir Oltean:
> > > > On Mon, Aug 30, 2021 at 09:36:23PM +0300, Vladimir Oltean wrote:
> > > > > On Mon, Aug 30, 2021 at 07:30:15PM +0100, Russell King (Oracle) wrote:
> > > > > > Can we postpone this after this merge window please, so I've got time
> > > > > > to properly review this. Thanks.
> > > > >
> > > > > Please review at your discretion, I've no intention to post a v3 right
> > > > > now, and to the best of my knowledge, RFC's are not even considered
> > > > > for
> > > > > direct inclusion in the git tree.
> > > >
> > > > Hello Russell, can you please review these patches if possible? I
> > > > would like to repost them soon.
> > > 
> > > I planned to test this on my board with the AR8031 (and add support
> > > there),
> > > but it seems I won't find time before my vacation, unfortunately.
> > 
> > Oh, but there isn't any "support" to be added I though, your conclusion
> > last time seemed to be that it only supported in-band autoneg ON?
> > I was going to add a patch to implement .validate_inband_aneg for the
> > at803x driver to mark that fact too, I just didn't do it in the RFC.
> > That should also fix the ENETC ports on the LS1028A-RDB which were
> > migrated to phylink while they didn't have the 'managed =
> > "in-band-status"'
> > OF property, and enable new kernels to still work with the old DT blob.
> > Or were you thinking of something else?
> 
> No, but I won't find time to test it within the next.. uhm, 30minutes
> until I call it a day ;)

Ok, if that is all, I can make sure on the NXP LS1028A-RDB that the
Atheros PHYs are always presented to phylink drivers as MLO_AN_INBAND,
never MLO_AN_PHY, and make sure that the enetc driver works in that
configuration regardless of device tree description.