netdev - Re: [PATCH net-next] sky2: Stop printing VPD info to debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210916151359.7bf742df@hermes.local>
Date:   Thu, 16 Sep 2021 15:13:59 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Mirko Lindner <mlindner@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] sky2: Stop printing VPD info to debugfs

On Thu, 16 Sep 2021 23:40:37 +0200
Heiner Kallweit <hkallweit1@...il.com> wrote:

> Sky2 is parsing the VPD and adds the parsed information to its debugfs
> file. This isn't needed in kernel, userspace tools like lspci can be
> used to display such information nicely. Therefore remove this from
> the driver.
> 
> lspci -vv:
> 
> Capabilities: [50] Vital Product Data
> 	Product Name: Marvell Yukon 88E8070 Gigabit Ethernet Controller
> 	Read-only fields:
> 		[PN] Part number: Yukon 88E8070
> 		[EC] Engineering changes: Rev. 1.0
> 		[MN] Manufacture ID: Marvell
> 		[SN] Serial number: AbCdEfG970FD4
> 		[CP] Extended capability: 01 10 cc 03
> 		[RV] Reserved: checksum good, 9 byte(s) reserved
> 	Read/write fields:
> 		[RW] Read-write area: 1 byte(s) free
> 	End
> 
> Relevant part in debugfs file:
> 
> 0000:01:00.0 Product Data
> Marvell Yukon 88E8070 Gigabit Ethernet Controller
>  Part Number: Yukon 88E8070
>  Engineering Level: Rev. 1.0
>  Manufacturer: Marvell
>  Serial Number: AbCdEfG970FD4
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Make sense lspci seems to have gotten better at handling this now.

Acked-by: Stephen Hemminger <stephen@...workplumber.org>