netdev - Re: [PATCH 2/3] libbpf: support detecting and attaching of writable tracepoint program

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e91eeff7-e091-3445-f27f-a30646cc5440@fb.com>
Date:   Thu, 16 Sep 2021 16:35:46 -0700
From:   Yonghong Song <yhs@...com>
To:     Hou Tao <houtao1@...wei.com>, Alexei Starovoitov <ast@...nel.org>
CC:     Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/3] libbpf: support detecting and attaching of writable
 tracepoint program



On 9/16/21 6:55 AM, Hou Tao wrote:
> Program on writable tracepoint is BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE,
> but its attachment is the same as BPF_PROG_TYPE_RAW_TRACEPOINT.
> 
> Signed-off-by: Hou Tao <houtao1@...wei.com>
> ---
>   tools/lib/bpf/libbpf.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 88d8825fc6f6..e6a1d552040c 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -7942,6 +7942,10 @@ static const struct bpf_sec_def section_defs[] = {
>   		.attach_fn = attach_raw_tp),
>   	SEC_DEF("raw_tp/", RAW_TRACEPOINT,
>   		.attach_fn = attach_raw_tp),
> +	SEC_DEF("raw_tracepoint_writable/", RAW_TRACEPOINT_WRITABLE,
> +		.attach_fn = attach_raw_tp),
> +	SEC_DEF("raw_tp_writable/", RAW_TRACEPOINT_WRITABLE,
> +		.attach_fn = attach_raw_tp),

Looks like initially ([1]) we don't have C bpf program test case for 
RAW_TRACEPOINT_WRITABLE, so the above sec definition is missing.

  [1] e950e843367d7 selftests: bpf: test writable buffers in raw tps

>   	SEC_DEF("tp_btf/", TRACING,
>   		.expected_attach_type = BPF_TRACE_RAW_TP,
>   		.is_attach_btf = true,
>