netdev - Re: [PATCH] selftests: nci: use int replace unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACwDmQDmK=rKJ56D_ythcb_TDBMeGJZq+iah-5Jqc8S6C45LbA@mail.gmail.com>
Date:   Thu, 16 Sep 2021 17:05:28 +0900
From:   Bongsu Jeon <bongsu.jeon2@...il.com>
To:     Xiang wangx <wangxiang@...rlc.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] selftests: nci: use int replace unsigned int

Sorry for missing a few comments about this commit message.
Please change the subject to fix grammatical errors.

On Thu, Sep 16, 2021 at 4:17 PM Bongsu Jeon <bongsu.jeon2@...il.com> wrote:
>
> On Thu, Sep 16, 2021 at 2:55 PM Xiang wangx <wangxiang@...rlc.com> wrote:
> >
> > Should not use unsigned expression compared with zero

Please put a period at the end of the sentence.

> >
> > Signed-off-by: Xiang wangx <wangxiang@...rlc.com>
> > ---
> >  tools/testing/selftests/nci/nci_dev.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
> > index e1bf55dabdf6..162c41e9bcae 100644
> > --- a/tools/testing/selftests/nci/nci_dev.c
> > +++ b/tools/testing/selftests/nci/nci_dev.c
> > @@ -746,7 +746,7 @@ int read_write_nci_cmd(int nfc_sock, int virtual_fd, const __u8 *cmd, __u32 cmd_
> >                        const __u8 *rsp, __u32 rsp_len)
> >  {
> >         char buf[256];
> > -       unsigned int len;
> > +       int len;
> >
> >         send(nfc_sock, &cmd[3], cmd_len - 3, 0);
> >         len = read(virtual_fd, buf, cmd_len);
> > --
> > 2.20.1
> >
>
> Thanks for fixing it.
>
> Reviewed-by: Bongsu Jeon
>
> Best regards,
> Bongsu

Sorry for missing the comment for