netdev - Re: [PATCH v1 net] net: mscc: ocelot: remove buggy duplicate write to DEV_CLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210916113914.3mgy3jkwsfiqyg5f@skbuf>
Date:   Thu, 16 Sep 2021 11:39:15 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Colin Foster <colin.foster@...advantage.com>
CC:     Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 net] net: mscc: ocelot: remove buggy duplicate write to
 DEV_CLOCK_CFG

On Wed, Sep 15, 2021 at 06:23:40PM -0700, Colin Foster wrote:
> When updating ocelot to use phylink, a second write to DEV_CLOCK_CFG was
> mistakenly left in. It used the variable "speed" which, previously, would
> would have been assigned a value of OCELOT_SPEED_1000. In phylink the
> variable is be SPEED_1000, which is invalid for the
> DEV_CLOCK_LINK_SPEED macro. Removing it as unnecessary and buggy.
> 
> Fixes: e6e12df625f2 ("net: mscc: ocelot: convert to phylink")
> Signed-off-by: Colin Foster <colin.foster@...advantage.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>