netdev - Re: [PATCH net-next 09/10] netfilter: x_tables: never register tables by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210916122443.GD20414@breakpoint.cc>
Date:   Thu, 16 Sep 2021 14:24:43 +0200
From:   Florian Westphal <fw@...len.de>
To:     youling 257 <youling257@...il.com>
Cc:     Florian Westphal <fw@...len.de>, pablo@...filter.org,
        netfilter-devel@...r.kernel.org, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 09/10] netfilter: x_tables: never register
 tables by default

youling 257 <youling257@...il.com> wrote:
> kernel 5.15rc1.

Thanks, this is due to a leftover __init annotation.
This patch should fix the bug:

diff --git a/net/ipv4/netfilter/iptable_raw.c b/net/ipv4/netfilter/iptable_raw.c
--- a/net/ipv4/netfilter/iptable_raw.c
+++ b/net/ipv4/netfilter/iptable_raw.c
@@ -42,7 +42,7 @@ iptable_raw_hook(void *priv, struct sk_buff *skb,
 
 static struct nf_hook_ops *rawtable_ops __read_mostly;
 
-static int __net_init iptable_raw_table_init(struct net *net)
+static int iptable_raw_table_init(struct net *net)
 {
 	struct ipt_replace *repl;
 	const struct xt_table *table = &packet_raw;