netdev - Re: [PATCH net-next] net: socket: add the case sock_no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210917183311.2db5f332@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 17 Sep 2021 18:33:11 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yajun Deng <yajun.deng@...ux.dev>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: socket: add the case sock_no_xxx support

On Thu, 16 Sep 2021 20:29:43 +0800 Yajun Deng wrote:
> Those sock_no_{mmap, socketpair, listen, accept, connect, shutdown,
> sendpage} functions are used many times in struct proto_ops, but they are
> meaningless. So we can add them support in socket and delete them in struct
> proto_ops.

So the reason to do this is.. what exactly?

Removing a couple empty helpers (which is not even part of this patch)?

I'm not sold, sorry.