netdev - Re: [PATCH v2 0/4] Introduce and use absolute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <202109182026.18IKQLng003683@valdese.nms.ulrich-teichert.org>
Date:   Sat, 18 Sep 2021 22:26:21 +0200 (CEST)
From:   Ulrich Teichert <krypton@...ich-teichert.org>
To:     torvalds@...ux-foundation.org (Linus Torvalds)
Cc:     krypton@...ich-teichert.org (Ulrich Teichert),
        mcree@...on.net.nz (Michael Cree),
        linux@...ck-us.net (Guenter Roeck),
        rth@...ddle.net (Richard Henderson),
        ink@...assic.park.msu.ru (Ivan Kokshaysky),
        mattst88@...il.com (Matt Turner),
        James.Bottomley@...senpartnership.com (James E . J . Bottomley),
        deller@....de (Helge Deller),
        davem@...emloft.net (David S . Miller),
        kuba@...nel.org (Jakub Kicinski),
        linux-alpha@...r.kernel.org (alpha),
        geert@...ux-m68k.org (Geert Uytterhoeven),
        linux-kernel@...r.kernel.org (Linux Kernel Mailing List),
        linux-parisc@...r.kernel.org, netdev@...r.kernel.org (Netdev),
        linux-sparse@...r.kernel.org (Sparse Mailing-list)
Subject: Re: [PATCH v2 0/4] Introduce and use absolute_pointer macro

Hi,

> > > On Thu, Sep 16, 2021 at 11:35:36AM -0700, Linus Torvalds wrote:
> > > > Naah. I think the Jensen actually had an ISA slot. Came with a
> > > > whopping 8MB too, so the ISA DMA should work just fine.
> > > >
> > > > Or maybe it was EISA only? I really don't remember.
> >
> > It's EISA only. I've made some pictures of a somewhat dusty inside of
> > a Jensen with 4 EISA cards (from bottom to top: SCSI, video, 2x network):
> 
> Ok.
> 
> Looking around the config options, there _are_ systems with ISA slots,
> but it's not the old Jensen one. It's apparently some evaluation
> boards but also the "AlphaPC64" one.
> 
> So we do want CONFIG_ISA for alpha, even if not Jensen.
> 
> (I forget which alpha I had. For some reason I want to think I had an
> EISA machine and probably Jensen. Maybe upgraded to a 164 later?)

Well, as this was way back in 1995, it was perhaps a Multia? Also
named UDB, a small "booksize" model.

> > I could not get a recent kernel to boot, but it's booting ancient kernels
> > just fine:
> >
> > Linux version 2.4.27-2-generic (tretkowski@...tille) (gcc version 3.3.5 (Debian 1:3.3.5-12)) #1 Sun May 29 18:40:58 UTC 2005
> 
> Ouch. Without having some kind of bisection, I guess we'll never know.
> And I assume it's not really been tested since, so it could be
> multiple reasons, including compiler updates causing dodgy code to not
> work etc etc.

Well, I doubt that bisecting will be practical going that way back.

> > While we're at it, during my vain attempts to get new kernels to boot,
> > I tried to disable PCI support to make the kernels smaller (after all,
> > the Jensen has only EISA, so what good would PCI support for?) and
> > got it to compile with the attached patch (which fixes some warnings,
> > too).
> 
> Can you send me your Jensen config?

Sure, attached here. I don't know if it helps - I can't tell you why I
used 4.18-rc5 for it, that was in 2018... Oh man, I am spending too much
time at work...

> I do not see why you should be using that horrible __EXERN_INLINE. It
> will cause gcc to sometimes not inline at all, and not generate the
> out-of-line body either.
>
> Sometimes that is what you want: you want to generate one single body
> of the function, and particularly one that is _different_ from the
> inlining case (ie for inlining you want to do the simple thing, for
> out-of-line you do something fancier).
> 
> But that isn't the case here, so this looks like a workaround for
> something else. But this code does end up using preprocessor
> concatenation etc, so I might be missing some case.

I was just tinkering with it to get it compiled without warning,
I certainly didn't get the big picture :-/

HTH,
Uli
-- 
Dipl. Inf. Ulrich Teichert|e-mail: Ulrich.Teichert@....de | Listening to:
Stormweg 24               |Eat Lipstick: Dirty Little Secret, The Baboon Show:
24539 Neumuenster, Germany|Work Work Work, The Bellrays: Bad Reaction

View attachment ".config" of type "text/plain" (47735 bytes)