netdev - Re: [PATCH] ovs: Only clear tstamp when changing namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpX4hQc3AHgVvfydZ9us0Rt21p5za849z1kgt-sLXSnWTQ@mail.gmail.com>
Date:   Mon, 20 Sep 2021 09:40:51 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Tyler Stachecki <stachecki.tyler@...il.com>
Cc:     fankaixi.li@...edance.com, xiexiaohui.xxh@...edance.com,
        "Cong Wang ." <cong.wang@...edance.com>,
        Pravin B Shelar <pshelar@....org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        dev@...nvswitch.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ovs: Only clear tstamp when changing namespaces

On Sun, Sep 19, 2021 at 10:44 PM Tyler Stachecki
<stachecki.tyler@...il.com> wrote:
> Sorry if this is a no-op -- I'm admittedly not familiar with this part
> of the tree.  I had added this check based on this discussion on the
> OVS mailing list:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2021-February/050966.html
>
> The motivation to add it was based on the fact that skb_scrub_packet
> is doing it conditionally as well, but you seem to indicate that
> skb_scrub_packet itself is already being done somewhere?

I mean, skb->tstamp has been cleared when crossing netns,
so: 1) you don't need to clear it again for this case; 2) clearly we
fix other cases with commit 01634047bf0d, so your patch break
it again.

Thanks.