netdev - Re: [net-next RFC PATCH 1/2] drivers: net: dsa: qca8k: add support for led config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUjZNA1Swo6Bv3/Q@lunn.ch>
Date:   Mon, 20 Sep 2021 20:55:48 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next RFC PATCH 1/2] drivers: net: dsa: qca8k: add support
 for led config

On Mon, Sep 20, 2021 at 08:08:50PM +0200, Ansuel Smith wrote:
> Add support for led control and led toggle.
> qca8337 and qca8327 switch have various reg to control port leds.
> The current implementation permit to toggle them on/off and to declare
> their blink rules based on the entry in the dts.
> They can also be declared in userspace by the "control_rule" entry in
> the led sysfs. When hw_mode is active (set by default) the leds blink
> based on the control_rule. There are 6 total control rule.
> Control rule that applies to phy0-3 commonly used for lan port.
> Control rule that applies to phy4 commonly used for wan port.
> Each phy port (5 in total) can have a maximum of 3 different leds
> attached. Each led can be turned off, blink at 4hz, off or set to
> hw_mode and follow their respecitve control rule. The hw_mode can be
> toggled using the sysfs entry and will be disabled on brightness or
> blink set.

Hi Ansuel

It is great you are using the LED subsystem for this. But we need to
split the code up into a generic part which can shared by any
switch/PHY and a driver specific part.

There has been a lot of discussion on the list about this. Maybe you
can help get us to a generic solution which can be used by everybody.

    Andrew