netdev - Re: [PATCH net] bnxt_en: Fix TX timeout when TX ring size is set to the smallest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163212900729.27858.970634646008254924.git-patchwork-notify@kernel.org>
Date:   Mon, 20 Sep 2021 09:10:07 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, kuba@...nel.org,
        gospo@...adcom.com
Subject: Re: [PATCH net] bnxt_en: Fix TX timeout when TX ring size is set to the
 smallest

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 20 Sep 2021 02:51:52 -0400 you wrote:
> The smallest TX ring size we support must fit a TX SKB with MAX_SKB_FRAGS
> + 1.  Because the first TX BD for a packet is always a long TX BD, we
> need an extra TX BD to fit this packet.  Define BNXT_MIN_TX_DESC_CNT with
> this value to make this more clear.  The current code uses a minimum
> that is off by 1.  Fix it using this constant.
> 
> The tx_wake_thresh to determine when to wake up the TX queue is half the
> ring size but we must have at least BNXT_MIN_TX_DESC_CNT for the next
> packet which may have maximum fragments.  So the comparison of the
> available TX BDs with tx_wake_thresh should be >= instead of > in the
> current code.  Otherwise, at the smallest ring size, we will never wake
> up the TX queue and will cause TX timeout.
> 
> [...]

Here is the summary with links:
  - [net] bnxt_en: Fix TX timeout when TX ring size is set to the smallest
    https://git.kernel.org/netdev/net/c/5bed8b0704c9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html