netdev - Re: Re: [PATCH net-next] net: net_namespace: Fix undefined member in key_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202109202029339411609@linux.dev>
Date:   Mon, 20 Sep 2021 20:29:36 +0800
From:   "yajun.deng@...ux.dev" <yajun.deng@...ux.dev>
To:     "Cong Wang" <xiyou.wangcong@...il.com>
Cc:     davem <davem@...emloft.net>, kuba <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH net-next] net: net_namespace: Fix undefined member in key_remove_domain()

From: Cong Wang
Date: 2021-09-20 07:25
To: Yajun Deng
CC: David Miller; Jakub Kicinski; Linux Kernel Network Developers; LKML
Subject: Re: [PATCH net-next] net: net_namespace: Fix undefined member in key_remove_domain()
On Sat, Sep 18, 2021 at 7:28 AM Yajun Deng <yajun.deng@...ux.dev> wrote:
>
> The key_domain member in struct net only exists if we define CONFIG_KEYS.
> So we should add the define when we used key_domain.
 
But key_remove_domain() is just a nop if !CONFIG_KEYS:
 
#else /* CONFIG_KEYS */
...
#define key_remove_domain(d)            do { } while(0) 

Yes, you're right.
 
So what exactly are you fixing?
 
Thanks.