netdev - bgmac regression: hang while probing on BCM47189

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACna6ryn-gmGm0uKEd_gfNgLkGTNdKi=J=Akz5tp4nZGcZB9gQ@mail.gmail.com>
Date:   Mon, 20 Sep 2021 14:44:38 +0200
From:   Rafał Miłecki <zajec5@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Network Development <netdev@...r.kernel.org>
Subject: bgmac regression: hang while probing on BCM47189

Hi,

commit 34322615cbaa ("net: bgmac: Mask interrupts during probe")
caused a regression on my Tenda AC9 router (BCM47189 SoC that belongs
to the BCM53573 family).

Calling bgmac_chip_intrs_off() that early in a probe function - for
the *second* eth interface - simply hangs my device.

I didn't see any problems caused by not having that call in the first place.
A solution seems to be also to call bgmac_clk_enable() *first*.

Should that call to the bgmac_chip_intrs_off() be conditional? Or
should we reorder bgmac_chip_intrs_off() and bgmac_clk_enable()?

-- 
Rafał