netdev - Re: [PATCH net-next 4/4] tcp: remove sk_{tr}x_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c475a970-82ae-f4e0-a424-afe24c182f2d@gmail.com>
Date:   Wed, 22 Sep 2021 11:01:18 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        Eric Dumazet <edumazet@...gle.com>, mptcp@...ts.linux.dev
Subject: Re: [PATCH net-next 4/4] tcp: remove sk_{tr}x_skb_cache



On 9/22/21 10:26 AM, Paolo Abeni wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> This reverts the following patches :
> 
> - commit 2e05fcae83c4 ("tcp: fix compile error if !CONFIG_SYSCTL")
> - commit 4f661542a402 ("tcp: fix zerocopy and notsent_lowat issues")
> - commit 472c2e07eef0 ("tcp: add one skb cache for tx")
> - commit 8b27dae5a2e8 ("tcp: add one skb cache for rx")
> 
> Having a cache of one skb (in each direction) per TCP socket is fragile,
> since it can cause a significant increase of memory needs,
> and not good enough for high speed flows anyway where more than one skb
> is needed.
> 
> We want instead to add a generic infrastructure, with more flexible
> per-cpu caches, for alien NUMA nodes.
> 
> Acked-by: Paolo Abeni <pabeni@...hat.com>
> Acked-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---

Thanks Paolo for taking care of MPTCP bits.