netdev - Re: [PATCH net-next] net: dsa: sja1105: stop using priv->vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d78f2bab-6c2a-73d3-080a-d5607af9be6e@gmail.com>
Date:   Wed, 22 Sep 2021 11:40:19 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next] net: dsa: sja1105: stop using priv->vlan_aware

On 9/22/21 11:38 AM, Vladimir Oltean wrote:
> On Wed, Sep 22, 2021 at 07:24:43PM +0300, Vladimir Oltean wrote:
>> On Wed, Sep 22, 2021 at 05:44:01PM +0300, Vladimir Oltean wrote:
>>> +	if (!dsa_port_is_vlan_filtering(ds, port) &&
>>
>> omg, what did I just send....
>> I amended the commit a few times but forgot to format-patch it again.
>> The dsa_port_is_vlan_filtering prototype takes a "dp" argument, this
>> patch doesn't even build. Please toss it to the bin where it belongs.
> 
> Superseded by v2 which has message ID 20210922183655.2680551-1-vladimir.oltean@....com
> Florian, please note that I did not preserve your Reviewed-by tag, due
> to the patch looking fairly differently now.

Yes I completely missed that argument misuse, the changes look logically
correct, too quick in reviewing I guess :)
-- 
Florian