netdev - RE: [PATCH] usbnet: ipheth: fix connectivity with iOS 14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79d05aaa5052408897aeb8039c6a1582@bingner.com>
Date:   Wed, 22 Sep 2021 20:11:52 +0000
From:   Sam Bingner <sam@...gner.com>
To:     Oliver Neukum <oneukum@...e.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
CC:     "David S. Miller" <davem@...emloft.net>,
        Martin Habets <mhabets@...arflare.com>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        Shannon Nelson <snelson@...sando.io>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Matti Vuorela <matti.vuorela@...factor.fi>,
        Jakub Kicinski <kuba@...nel.org>,
        "Yves-Alexis Perez" <corsac@...sac.net>
Subject: RE: [PATCH] usbnet: ipheth: fix connectivity with iOS 14

Sorry I didn't have time to research this further to prove it was a regression - but there is now somebody else who has done so and created a patch.  I thought it might be good to give a link to it to you guys.  It caused problems on all iOS versions AFAIK.  The patch and discussion is available at:

https://github.com/openwrt/openwrt/pull/4084

Sam

-----Original Message-----
From: Oliver Neukum <oneukum@...e.com> 
Sent: Monday, February 22, 2021 2:10 AM
To: Sam Bingner <sam@...gner.com>; linux-usb@...r.kernel.org
Cc: David S. Miller <davem@...emloft.net>; Martin Habets <mhabets@...arflare.com>; Luc Van Oostenryck <luc.vanoostenryck@...il.com>; Shannon Nelson <snelson@...sando.io>; Michael S. Tsirkin <mst@...hat.com>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Matti Vuorela <matti.vuorela@...factor.fi>; Jakub Kicinski <kuba@...nel.org>; Yves-Alexis Perez <corsac@...sac.net>
Subject: Re: [PATCH] usbnet: ipheth: fix connectivity with iOS 14

Am Sonntag, den 21.02.2021, 10:42 +0000 schrieb Sam Bingner:
> There seems to be a problem with this patch:
> 
> Whenever the iPhone sends a packet to the tethered device that is 1500 bytes long, it gets the error "ipheth 1-1:4.2: ipheth_rcvbulk_callback: urb status: -79" on the connected device and stops passing traffic.  I am able to bring it back up by shutting and unshutting the interface, but the same thing happens very quickly.   I noticed that this patch dropped the max USB packet size from 1516 to 1514 bytes, so I decided to try lowering the MTU to 1498; this made the connection reliable and no more errors occurred.
> 
> It appears to me that the iPhone is still sending out 1516 bytes over USB for a 1500 byte packet and this patch makes USB abort when that happens?  I could duplicate reliably by sending a ping from the iphone (ping -s 1472) to the connected device, or vice versa as the reply would then break it.
> 
> I apologize if this reply doesn't end up where it should - I tried to reply to the last message in this thread but I wasn't actually *on* the thread so I had to just build it as much as possible myself.

Is this a regression? Does it work after reverting the patch? Which version of iOS?

	Regards
		Oliver