netdev - Re: [PATCH v2 bpf-next] libbpf: Use sysconf to simplify libbpf_num_possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210923024944.GA446@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date:   Wed, 22 Sep 2021 19:49:44 -0700
From:   Muhammad Falak Wani <mwani@...ux.microsoft.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Muhammad Falak R Wani <falakreyaz@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 bpf-next] libbpf: Use sysconf to simplify
 libbpf_num_possible_cpus

> > This approach is unfortunately broken, see also commit e00c7b216f34 ("bpf: fix
> > multiple issues in selftest suite and samples") for more details:
> 
> Oh, that predates me. Thanks, Daniel!
Thank you Daniel for the context. 

> 
> Sorry, Muhammad, seems like current implementation is there for a
> reason and will have to stay. Thanks a lot for working on this,
> though. Hopefully you can help with other issues, though.
> 
No worries at all, it was a good experience for me & I will
try to help here and there for sure.

Thank you again!

-mfrw