netdev - Re: [PATCH v2] net: check return value of rhashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210923055802.2dc3833a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 23 Sep 2021 05:58:02 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     MichelleJin <shjy180909@...il.com>
Cc:     davem@...emloft.net, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
        johannes@...solutions.net, saeedm@...dia.com, leon@...nel.org,
        roid@...dia.com, paulb@...dia.com, lariel@...dia.com,
        ozsh@...dia.com, cmi@...dia.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: check return value of rhashtable_init

On Thu, 23 Sep 2021 12:53:17 +0000 MichelleJin wrote:
> When rhashtable_init() fails, it returns -EINVAL.
> However, since error return value of rhashtable_init is not checked,
> it can cause use of uninitialized pointers.
> So, fix unhandled errors of rhashtable_init and possible memory leaks.
> 
> Signed-off-by: MichelleJin <shjy180909@...il.com>

Please split this into 3 patches (ipv6, mlx, mac80211).