netdev - Re: [PATCH RFC net-next 2/2] net/sched: Add flower2 packet classifier based on flower and PANDA parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAPEopiv8pUHkHgh=WzkEyS-ZNxMnywxpDNLcdZDwTk9YYpyUQ@mail.gmail.com>
Date:   Thu, 23 Sep 2021 10:33:57 -0300
From:   Felipe Magno de Almeida <felipe@...anda.io>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>,
        Jiří Pírko <jiri@...nulli.us>,
        xiyou.wangcong@...il.com, netdev@...r.kernel.org,
        boris.sukholitko@...adcom.com, vadym.kochan@...ision.eu,
        ilya.lifshits@...adcom.com, vladbu@...dia.com, idosch@...sch.org,
        paulb@...dia.com, dcaratti@...hat.com, amritha.nambiar@...el.com,
        sridhar.samudrala@...el.com, Tom Herbert <tom@...anda.io>,
        Pedro Tammela <pctammela@...atatu.com>, eric.dumazet@...il.com
Subject: Re: [PATCH RFC net-next 2/2] net/sched: Add flower2 packet classifier
 based on flower and PANDA parser

Hello Marcelo,

On Wed, Sep 22, 2021 at 7:32 PM Marcelo Ricardo Leitner
<marcelo.leitner@...il.com> wrote:
>
> On Thu, Sep 16, 2021 at 05:00:41PM -0300, Felipe Magno de Almeida wrote:
> > +int fl2_panda_parse(struct sk_buff *skb, struct fl2_flow_key* frame)
> > +{
> > +     int err;
> > +     struct panda_parser_big_metadata_one mdata;
> > +     void *data;
> > +     size_t pktlen;
> > +
> > +     memset(&mdata, 0, sizeof(mdata.panda_data));
> > +     memcpy(&mdata.frame, frame, sizeof(struct fl2_flow_key));
> > +
> > +     err = skb_linearize(skb);
>
> Oh ow. Hopefully this is just for the RFC?

Yes, this is just for the RFC. Our focus was showing how PANDA
can easily replace flow dissector by using a useful and complex
use-case (flower) and extending it easily. A proper submission
would not linearize, but first we need feedback on how this
submission should look like.

Kind regards,
--
Felipe Magno de Almeida
Developer @ SiPanda
Owner @ Expertise Solutions
www: https://expertise.dev
phone: +55 48 9 9681.0157
LinkedIn: in/felipealmeida