netdev - Re: [PATCH net-next] ptp: clockmatrix: use rsmu driver to access i2c/spi bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210923094146.0caaf4e2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 23 Sep 2021 09:41:46 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Min Li <min.li.xe@...esas.com>
Cc:     "richardcochran@...il.com" <richardcochran@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>
Subject: Re: [PATCH net-next] ptp: clockmatrix: use rsmu driver to access
 i2c/spi bus

On Thu, 23 Sep 2021 16:29:44 +0000 Min Li wrote:
> > On Wed, 22 Sep 2021 09:57:14 -0400 min.li.xe@...esas.com wrote:  
> > > From: Min Li <min.li.xe@...esas.com>
> > >
> > > rsmu (Renesas Synchronization Management Unit ) driver is located in
> > > drivers/mfd and responsible for creating multiple devices including
> > > clockmatrix phc, which will then use the exposed regmap and mutex
> > > handle to access i2c/spi bus.  
> > 
> > Does not build on 32 bit. You need to use division helpers.  
> 
> Hi Jakub
> 
> I did build it through 32 bit arm and didn't get the problem.
> 
> make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi-

We're testing x86, maybe arm32 can handle 64bit divisions natively?

ERROR: modpost: "__divdi3" [drivers/ptp/ptp_clockmatrix.ko] undefined!
ERROR: modpost: "__udivdi3" [drivers/ptp/ptp_clockmatrix.ko] undefined!