netdev - Re: [RFC/PATCH 04/18] ravb: Enable aligned_tx and tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bb71719-54df-252f-0d55-8c02f84a9624@omp.ru>
Date:   Thu, 23 Sep 2021 21:10:38 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Biju Das <biju.das.jz@...renesas.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
CC:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Andrew Lunn <andrew@...n.ch>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Adam Ford <aford173@...il.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        <netdev@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>
Subject: Re: [RFC/PATCH 04/18] ravb: Enable aligned_tx and tx_counters for
 RZ/G2L

On 9/23/21 9:05 PM, Sergey Shtylyov wrote:

>    Somehow this patch haven't reached my OMP email -- I got it only thru
>  the linux-renesas-soc list... :-/
> 
>> RZ/G2L need 4byte address alignment like R-Car Gen2 and
>> it has tx_counters like R-Car Gen3. This patch enable
>> these features for RZ/G2L.
>>
>> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
[...]
>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
>> index 54c4d31a6950..d38fc33a8e93 100644
>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>> @@ -2114,6 +2114,8 @@ static const struct ravb_hw_info rgeth_hw_info = {
>>  	.set_feature = ravb_set_features_rgeth,
>>  	.dmac_init = ravb_dmac_init_rgeth,
>>  	.emac_init = ravb_rgeth_emac_init,
>> +	.aligned_tx = 1,
>> +	.tx_counters = 1,
> 
>    Mhm, I don't see a connection between those 2 (other than they're both for RX). And anyway, this prolly

  TX, of/c. :-)

> should be a part of the previous patch...
> 
> [...]

MBR, Sergey