[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1e9d1d3c-0846-077e-8e1a-e06ff86c00fa@omp.ru>
Date: Fri, 24 Sep 2021 22:35:38 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Biju Das <biju.das.jz@...renesas.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
CC: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
Andrew Lunn <andrew@...n.ch>,
Sergei Shtylyov <sergei.shtylyov@...il.com>,
"Geert Uytterhoeven" <geert+renesas@...der.be>,
Adam Ford <aford173@...il.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
<netdev@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>,
Chris Paterson <Chris.Paterson2@...esas.com>,
Biju Das <biju.das@...renesas.com>
Subject: Re: [RFC/PATCH 11/18] ravb: Add rx_2k_buffers to struct ravb_hw_info
On 9/23/21 5:08 PM, Biju Das wrote:
> R-Car AVB-DMAC has Maximum 2K size on RZ buffer.
> We need to Allow for changing the MTU within the
> limit of the maximum size of a descriptor (2048 bytes).
>
> Add a rx_2k_buffers hw feature bit to struct ravb_hw_info
> to add this constraint only for R-Car.
>
> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> ---
> drivers/net/ethernet/renesas/ravb.h | 1 +
> drivers/net/ethernet/renesas/ravb_main.c | 8 ++++++--
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
> index 7532cb51d7b8..ab4909244276 100644
> --- a/drivers/net/ethernet/renesas/ravb.h
> +++ b/drivers/net/ethernet/renesas/ravb.h
> @@ -1033,6 +1033,7 @@ struct ravb_hw_info {
> unsigned magic_pkt:1; /* E-MAC supports magic packet detection */
> unsigned mii_rgmii_selection:1; /* E-MAC supports mii/rgmii selection */
> unsigned half_duplex:1; /* E-MAC supports half duplex mode */
> + unsigned rx_2k_buffers:1; /* AVB-DMAC has Max 2K buf size on RX */
It seems more flexible to specify the buffer size, not just a bit like this...
[...]
MBR, Sergey
Powered by blists - more mailing lists