netdev - Re: [PATCH v2] iwlwifi: pcie: add configuration of a Wi-Fi adapter on Dell XPS 15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcdb371094870ef2cbb599e20b4a35512efbd4d6.camel@intel.com>
Date:   Fri, 24 Sep 2021 08:48:59 +0000
From:   "Coelho, Luciano" <luciano.coelho@...el.com>
To:     "vladimir.zapolskiy@...aro.org" <vladimir.zapolskiy@...aro.org>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "felash@...il.com" <felash@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] iwlwifi: pcie: add configuration of a Wi-Fi adapter on
 Dell XPS 15

On Thu, 2021-09-23 at 17:38 +0300, Vladimir Zapolskiy wrote:
> There is a Killer AX1650 2x2 Wi-Fi 6 and Bluetooth 5.1 wireless adapter
> found on Dell XPS 15 (9510) laptop, its configuration was present on
> Linux v5.7, however accidentally it has been removed from the list of
> supported devices, let's add it back.
> 
> The problem is manifested on driver initialization:
> 
>   Intel(R) Wireless WiFi driver for Linux
>   iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
>   iwlwifi: No config found for PCI dev 43f0/1651, rev=0x354, rfid=0x10a100
>   iwlwifi: probe of 0000:00:14.3 failed with error -22
> 
> Bug: https://bugzilla.kernel.org/show_bug.cgi?id=213939
> Fixes: 3f910a25839b ("iwlwifi: pcie: convert all AX101 devices to the device tables")
> Cc: Julien Wajsberg <felash@...il.com>
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
> ---
> Changes from v1 to v2:
> * moved the added lines in a way to preserve a numerical order by devid.
> 
>  drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> index 61b2797a34a8..3744c5e76519 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> @@ -547,6 +547,8 @@ static const struct iwl_dev_info iwl_dev_info_table[] = {
>  	IWL_DEV_INFO(0x43F0, 0x0074, iwl_ax201_cfg_qu_hr, NULL),
>  	IWL_DEV_INFO(0x43F0, 0x0078, iwl_ax201_cfg_qu_hr, NULL),
>  	IWL_DEV_INFO(0x43F0, 0x007C, iwl_ax201_cfg_qu_hr, NULL),
> +	IWL_DEV_INFO(0x43F0, 0x1651, killer1650s_2ax_cfg_qu_b0_hr_b0, NULL),

Instead of NULL at the end, please use iwl_ax201_killer_1650s_name.

> +	IWL_DEV_INFO(0x43F0, 0x1652, killer1650i_2ax_cfg_qu_b0_hr_b0, NULL),

...and iwl_ax201_killer_1650i_name here.


--
Cheers,
Luca.