[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210924090537.48972-1-lxu@maxlinear.com>
Date: Fri, 24 Sep 2021 17:05:37 +0800
From: Xu Liang <lxu@...linear.com>
To: <andrew@...n.ch>, <hkallweit1@...il.com>, <netdev@...r.kernel.org>,
<davem@...emloft.net>, <kuba@...nel.org>,
<vee.khee.wong@...ux.intel.com>
CC: <linux@...linux.org.uk>, <hmehrtens@...linear.com>,
<tmohren@...linear.com>, <mohammad.athari.ismail@...el.com>,
Xu Liang <lxu@...linear.com>
Subject: [PATCH] net: phy: enhance GPY115 loopback disable function
GPY115 need reset PHY when it comes out from loopback mode if the firmware
version number (lower 8 bits) is equal to or below 0x76.
Signed-off-by: Xu Liang <lxu@...linear.com>
---
drivers/net/phy/mxl-gpy.c | 30 ++++++++++++++++++++++++++++--
1 file changed, 28 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c
index 2d5d5081c3b6..3ef62d5c4776 100644
--- a/drivers/net/phy/mxl-gpy.c
+++ b/drivers/net/phy/mxl-gpy.c
@@ -493,6 +493,32 @@ static int gpy_loopback(struct phy_device *phydev, bool enable)
return ret;
}
+static int gpy115_loopback(struct phy_device *phydev, bool enable)
+{
+ int ret;
+ int fw_minor;
+
+ if (enable)
+ return gpy_loopback(phydev, enable);
+
+ /* Show GPY PHY FW version in dmesg */
+ ret = phy_read(phydev, PHY_FWV);
+ if (ret < 0)
+ return ret;
+
+ fw_minor = FIELD_GET(PHY_FWV_MINOR_MASK, ret);
+ if (fw_minor > 0x0076)
+ return gpy_loopback(phydev, 0);
+
+ ret = phy_modify(phydev, MII_BMCR, BMCR_LOOPBACK, BMCR_RESET);
+ if (!ret) {
+ /* Some delay for the reset complete. */
+ msleep(100);
+ }
+
+ return ret;
+}
+
static struct phy_driver gpy_drivers[] = {
{
PHY_ID_MATCH_MODEL(PHY_ID_GPY2xx),
@@ -527,7 +553,7 @@ static struct phy_driver gpy_drivers[] = {
.handle_interrupt = gpy_handle_interrupt,
.set_wol = gpy_set_wol,
.get_wol = gpy_get_wol,
- .set_loopback = gpy_loopback,
+ .set_loopback = gpy115_loopback,
},
{
PHY_ID_MATCH_MODEL(PHY_ID_GPY115C),
@@ -544,7 +570,7 @@ static struct phy_driver gpy_drivers[] = {
.handle_interrupt = gpy_handle_interrupt,
.set_wol = gpy_set_wol,
.get_wol = gpy_get_wol,
- .set_loopback = gpy_loopback,
+ .set_loopback = gpy115_loopback,
},
{
.phy_id = PHY_ID_GPY211B,
--
2.17.1
Powered by blists - more mailing lists