netdev - Re: [PATCH net-next 6/6 v6] net: dsa: rtl8366: Drop and depromote pointless prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Sep 2021 21:56:25 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Mauri Sandberg <sandberg@...lfence.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        DENG Qingfang <dqfext@...il.com>
Subject: Re: [PATCH net-next 6/6 v6] net: dsa: rtl8366: Drop and depromote
 pointless prints

On Sat, Sep 25, 2021 at 03:23:11PM +0200, Linus Walleij wrote:
> We don't need a message for every VLAN association, dbg
> is fine. The message about adding the DSA or CPU
> port to a VLAN is directly misleading, this is perfectly
> fine.
>
> Cc: Vladimir Oltean <olteanv@...il.com>
> Cc: Mauri Sandberg <sandberg@...lfence.com>
> Cc: Alvin Šipraga <alsi@...g-olufsen.dk>
> Cc: DENG Qingfang <dqfext@...il.com>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
> ChangeLog v5->v6:
> - No changes just resending with the rest of the
>   patches.
> ChangeLog v4->v5:
> - Collect Florians review tag.
> ChangeLog v1->v4:
> - New patch to deal with confusing messages and too talkative
>   DSA bridge.
> ---
>  drivers/net/dsa/rtl8366.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/dsa/rtl8366.c b/drivers/net/dsa/rtl8366.c
> index f815cd16ad48..bb6189aedcd4 100644
> --- a/drivers/net/dsa/rtl8366.c
> +++ b/drivers/net/dsa/rtl8366.c
> @@ -318,12 +318,9 @@ int rtl8366_vlan_add(struct dsa_switch *ds, int port,
>  		return ret;
>  	}
>
> -	dev_info(smi->dev, "add VLAN %d on port %d, %s, %s\n",
> -		 vlan->vid, port, untagged ? "untagged" : "tagged",
> -		 pvid ? " PVID" : "no PVID");
> -
> -	if (dsa_is_dsa_port(ds, port) || dsa_is_cpu_port(ds, port))
> -		dev_err(smi->dev, "port is DSA or CPU port\n");
> +	dev_dbg(smi->dev, "add VLAN %d on port %d, %s, %s\n",
> +		vlan->vid, port, untagged ? "untagged" : "tagged",
> +		pvid ? " PVID" : "no PVID");

This is better, not going to complain too much, but I mean,
rtl8366_set_vlan and rtl8366_set_pvid already have debugging prints in
them, how can you tolerate so many superfluous prints, what do they
bring useful?

>
>  	member |= BIT(port);
>
> @@ -356,7 +353,7 @@ int rtl8366_vlan_del(struct dsa_switch *ds, int port,
>  	struct realtek_smi *smi = ds->priv;
>  	int ret, i;
>
> -	dev_info(smi->dev, "del VLAN %04x on port %d\n", vlan->vid, port);
> +	dev_dbg(smi->dev, "del VLAN %d on port %d\n", vlan->vid, port);
>
>  	for (i = 0; i < smi->num_vlan_mc; i++) {
>  		struct rtl8366_vlan_mc vlanmc;
> --
> 2.31.1
>