netdev - Re: [PATCH net-next 6/6 v6] net: dsa: rtl8366: Drop and depromote pointless prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY0dp7nNCsxOdXsdfbBMO1AK5KfW8SqvuZ0Gmt-QwmqVg@mail.gmail.com>
Date:   Sun, 26 Sep 2021 00:54:45 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Mauri Sandberg <sandberg@...lfence.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        DENG Qingfang <dqfext@...il.com>
Subject: Re: [PATCH net-next 6/6 v6] net: dsa: rtl8366: Drop and depromote
 pointless prints

On Sat, Sep 25, 2021 at 8:56 PM Vladimir Oltean <olteanv@...il.com> wrote:

> > -     dev_info(smi->dev, "add VLAN %d on port %d, %s, %s\n",
> > -              vlan->vid, port, untagged ? "untagged" : "tagged",
> > -              pvid ? " PVID" : "no PVID");
> > -
> > -     if (dsa_is_dsa_port(ds, port) || dsa_is_cpu_port(ds, port))
> > -             dev_err(smi->dev, "port is DSA or CPU port\n");
> > +     dev_dbg(smi->dev, "add VLAN %d on port %d, %s, %s\n",
> > +             vlan->vid, port, untagged ? "untagged" : "tagged",
> > +             pvid ? " PVID" : "no PVID");
>
> This is better, not going to complain too much, but I mean,
> rtl8366_set_vlan and rtl8366_set_pvid already have debugging prints in
> them, how can you tolerate so many superfluous prints, what do they
> bring useful?

I actually use them ... I suppose one can use ftrace instead
and/or gdb, but I'm one of those die hard printk() debuggers
and I like to follow what happens like that.

When the driver gets mature we can delete most  or all of the
dev_dbg() messages I think.

Yours,
Linus Walleij