netdev - Re: [PATCH net-next v3 0/3] check return value of rhashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Sep 2021 16:26:28 +0900
From:   진성희 <shjy180909@...il.com>
To:     davem@...emloft.net, kuba@...nel.org, yoshfuji@...ux-ipv6.org,
        dsahern@...nel.org, johannes@...solutions.net
Cc:     saeedm@...dia.com, leon@...nel.org, roid@...dia.com,
        paulb@...dia.com, ozsh@...dia.com, vladbu@...dia.com,
        lariel@...dia.com, cmi@...dia.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 0/3] check return value of rhashtable_init in
 mlx5e, ipv6, mac80211.

2021년 9월 25일 (토) 오후 3:10, MichelleJin <shjy180909@...il.com>님이 작성:
>
> When rhashtable_init() fails, it returns -EINVAL.
> However, since error return value of rhashtable_init is not checked,
> it can cause use of uninitialized pointers.
> So, fix unhandled errors of rhashtable_init.
> The three patches are essentially the same logic.
>
> v1->v2:
>  - change commit message
>  - fix possible memory leaks
> v2->v3:
>  - split patch into mlx5e, ipv6, mac80211.
>
> MichelleJin (3):
>   net/mlx5e: check return value of rhashtable_init
>   net: ipv6: check return value of rhashtable_init
>   net: mac80211: check return value of rhashtable_init
>
>  drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 14 +++++++++++---
>  net/ipv6/ila/ila_xlat.c                            |  6 +++++-
>  net/ipv6/seg6.c                                    |  6 +++++-
>  net/ipv6/seg6_hmac.c                               |  6 +++++-
>  net/mac80211/mesh_pathtbl.c                        |  5 ++++-
>  5 files changed, 30 insertions(+), 7 deletions(-)
>
> --
> 2.25.1
>

There are new build warnings in net/ipv6/seg6.c.
I'll fix it and send v4 soon.

Thank you.