netdev - Re: [PATCH 3/4] net: sis: Fix a function name in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Sep 2021 15:07:22 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Chris Snook <chris.snook@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Michael Chan <michael.chan@...adcom.com>,
        Francois Romieu <romieu@...zoreil.com>,
        Steve Glendinning <steve.glendinning@...well.net>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] net: sis: Fix a function name in comments

Le 25/09/2021 à 14:50, Cai Huoqing a écrit :
> Use dma_alloc_coherent() instead of pci_alloc_consistent(),
> because only dma_alloc_coherent() is called here.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> ---
>   drivers/net/ethernet/sis/sis190.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sis/sis190.c b/drivers/net/ethernet/sis/sis190.c
> index 3d1a18a01ce5..7e107407476a 100644
> --- a/drivers/net/ethernet/sis/sis190.c
> +++ b/drivers/net/ethernet/sis/sis190.c
> @@ -1070,7 +1070,7 @@ static int sis190_open(struct net_device *dev)
>   
>   	/*
>   	 * Rx and Tx descriptors need 256 bytes alignment.
> -	 * pci_alloc_consistent() guarantees a stronger alignment.
> +	 * dma_alloc_consistent() guarantees a stronger alignment.
>   	 */
>   	tp->TxDescRing = dma_alloc_coherent(&pdev->dev, TX_RING_BYTES,
>   					    &tp->tx_dma, GFP_KERNEL);
> 

Hi,
s/consistent/coherent/

CJ