netdev - Re: [PATCH net-next 5/6 v6] net: dsa: rtl8366: Fix a bug in deleting VLANs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Sep 2021 17:18:08 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Mauri Sandberg <sandberg@...lfence.com>,
        DENG Qingfang <dqfext@...il.com>
Subject: Re: [PATCH net-next 5/6 v6] net: dsa: rtl8366: Fix a bug in deleting
 VLANs

On 9/25/21 3:23 PM, Linus Walleij wrote:
> We were checking that the MC (member config) was != 0

Minor nitpick: actually we were checking the untag mask != 0, right?

The change itself seems fine though:

Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>

> for some reason, all we need to check is that the config
> has no ports, i.e. no members. Then it can be recycled.
> This must be some misunderstanding.
> 
> Fixes: 4ddcaf1ebb5e ("net: dsa: rtl8366: Properly clear member config")
> Cc: Vladimir Oltean <olteanv@...il.com>
> Cc: Mauri Sandberg <sandberg@...lfence.com>
> Cc: Alvin Šipraga <alsi@...g-olufsen.dk>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: DENG Qingfang <dqfext@...il.com>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
> ChangeLog v5->v6:
> - No changes just resending with the rest of the
>    patches.
> ChangeLog v4->v5:
> - Collect Florians review tag
> - Add Fixes tag
> ChangeLog v1->v4:
> - New patch for a bug found while fixing the other issues.
> ---
>   drivers/net/dsa/rtl8366.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/rtl8366.c b/drivers/net/dsa/rtl8366.c
> index 0672dd56c698..f815cd16ad48 100644
> --- a/drivers/net/dsa/rtl8366.c
> +++ b/drivers/net/dsa/rtl8366.c
> @@ -374,7 +374,7 @@ int rtl8366_vlan_del(struct dsa_switch *ds, int port,
>   			 * anymore then clear the whole member
>   			 * config so it can be reused.
>   			 */
> -			if (!vlanmc.member && vlanmc.untag) {
> +			if (!vlanmc.member) {
>   				vlanmc.vid = 0;
>   				vlanmc.priority = 0;
>   				vlanmc.fid = 0;
>