netdev - Re: [PATCH net-next v1] net: ethernet: emac: utilize of_net's of_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVCFHT7F2e6OOThM@lunn.ch>
Date:   Sun, 26 Sep 2021 16:35:09 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Christian Lamparter <chunkeey@...il.com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v1] net: ethernet: emac: utilize of_net's
 of_get_mac_address()

> +	err = of_get_mac_address(np, dev->ndev->dev_addr);
> +	if (err) {
> +		if (err != -EPROBE_DEFER)
> +			dev_err(&dev->ofdev->dev, "Can't get valid [local-]mac-address from OF !\n");
> +		return err;

I think there is a helper which does the if (err != -EPRODE_DEFER)
then print, but i cannot remember its name. Probably the script kids
will come along and convert it for you.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew