netdev - Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Sep 2021 17:58:54 +0200
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Daniel Borkmann <daniel@...earbox.net>,
        Ilya Leoshkevich <iii@...ux.ibm.com>,
        Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Konstantin Ryabitsev <konstantin@...uxfoundation.org>
Cc:     Yauheni Kaliuta <yauheni.kaliuta@...hat.com>,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about
 jit_data



Am 27.09.21 um 17:26 schrieb Daniel Borkmann:
> On 9/27/21 1:33 PM, Ilya Leoshkevich wrote:
>> On Mon, 2021-09-27 at 15:06 +0800, Tiezhu Yang wrote:
>>> Make sure to free jit_data through kfree() in the error path.
>>>
>>> Fixes: 1c8f9b91c456 ("bpf: s390: add JIT support for multi-function
>>> programs")
>>> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
>>> ---
>>>
>>> RESEND due to the following reason:
>>> [Can not connect to recipient's server because of unstable
>>> network or firewall filter. rcpt handle timeout, last handle
>>> info: Can not connect to vger.kernel.org]
>>>
>>>   arch/s390/net/bpf_jit_comp.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Nice catch, thanks!
>>
>> Acked-by: Ilya Leoshkevich <iii@...ux.ibm.com>

Makes sense.
Reviewed-by: Christian Borntraeger <borntraeger@...ibm.com>

> 
> Given s390, I presume this would be routed to Linus via Heiko/Vasily?

Yes, applied to the s390 tree.

Interestingly enough b4 cannot find the patch email on lore.
Looks like Tiezhu Yang has indeed connection issues with vger.
CC Konstantin, in case he knows something.