netdev - Re: [PATCH net] gve: DQO: Suppress unused var warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210927162128.4686b57d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 27 Sep 2021 16:21:28 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Bailey Forrest <bcf@...gle.com>
Cc:     Arnd Bergmann <arnd@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH net] gve: DQO: Suppress unused var warnings

On Mon, 27 Sep 2021 13:21:30 -0700 Bailey Forrest wrote:
> Apologies, resending as text
> 
> On Mon, Sep 27, 2021 at 2:59 AM Arnd Bergmann <arnd@...nel.org> wrote:
> >
> > On Sat, Jul 24, 2021 at 1:19 AM Bailey Forrest <bcf@...gle.com> wrote:  
> > >
> > > Some variables become unused when `CONFIG_NEED_DMA_MAP_STATE=n`.
> > >
> > > We only suppress when `CONFIG_NEED_DMA_MAP_STATE=n` in order to avoid
> > > false negatives.
> > >
> > > Fixes: a57e5de476be ("gve: DQO: Add TX path")
> > > Signed-off-by: Bailey Forrest <bcf@...gle.com>  
> >
> > Hi Bailey,
> >
> > I see that the warning still exists in linux-5.15-rc3 and net-next,
> > I'm building with my original patch[1] to get around the -Werror
> > warnings.
> >
> > Can you resend your patch, or should I resend mine after all?
> >
> >       Arnd
> >
> > [1] https://lore.kernel.org/all/20210721151100.2042139-1-arnd@kernel.org/  
> 
> Hi David/Jakub,
> 
> Any thoughts on my patch? I'm open to alternative suggestions for how
> to resolve this.
> 
> This patch still works and merges cleanly on HEAD.

Looks like fixing this on the wrong end, dma_unmap_len_set() 
and friends should always evaluate their arguments.